Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue Formatting #9

Closed
wants to merge 3 commits into from
Closed

Blue Formatting #9

wants to merge 3 commits into from

Conversation

tmsincomb
Copy link
Collaborator

@tmsincomb tmsincomb commented Jan 27, 2025

Changes

  • v0.9.1 blue formatting ran on existing code
  • had to modify import comment (ingest.py) and refactor string in sql text (api.py)
  • add blue hook
  • add pre-commit with blue

Usage

pip install -e .
pre-commit run --all-files

@tmsincomb tmsincomb added the enhancement New feature or request label Jan 27, 2025
@tmsincomb tmsincomb requested a review from tgbugs January 27, 2025 19:58
@tmsincomb tmsincomb self-assigned this Jan 27, 2025
@tgbugs
Copy link
Collaborator

tgbugs commented Jan 27, 2025

This is looking much better for merge back to master, however, I think we need to exclude api.py from blue because it makes it much harder to see and understand the sql generation that is going on since it spreads it out too much to be contained on a single page.

@tmsincomb tmsincomb changed the base branch from dev to master February 4, 2025 21:05
@tmsincomb tmsincomb changed the base branch from master to dev February 4, 2025 21:08
@tmsincomb tmsincomb mentioned this pull request Feb 4, 2025
@tmsincomb
Copy link
Collaborator Author

closing in favor or direct master branch #10

@tmsincomb tmsincomb closed this Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants